DAT: verify that a destination is able to write any ISO8601-compliant date string #9816

yurii-bidiuk · 2022-01-26T17:08:01Z

What

Fixes #5712

To verify that a destination is able to write any ISO8601-compliant date we added new messages with date and date-time formats to edge_case_messages.txt.
Destinations were able to process these messages but this occurs some errors on the assertions for acceptance tests. Some destinations process date/date-time in their specific format. For example, BigQuery destination converts a date-time string to a microsecond number. Some others destinations use different date-time formats to represent saved messages.
destination-bigquery-denormalized wasn't able to process date-time strings for any ISO8691 format

How

Added test cases with ISO date strings to edge_case_messages.txt.
For destinations whose date-time representation was different from the initial format, added converters to convert from initial format to destination format (e.g. initial format: "2021-01-03T01:01:01.544+01:00", snowflake format: "2021-01-03T00:01:02Z". To apply this converter for some specific destination you need to for override method requiresDateTimeConversionForSync() for testSync() or requiresDateTimeConversionForNormalizedSync() for testSyncWithNormalization(). After that override convertDateTime() and implement logic for your destination. DateTimeUtils contains static methods that take string in ISO8691 format and return date-time string in format required for every specific destination. That's the reason why I added methods like convertTo...Format()
Added method to parse any iso date-time and return date in the format that's applicable for bigquery-denormalized.

🚨 User Impact 🚨

There is no user impact

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed.

yurii-bidiuk · 2022-01-26T17:08:29Z

/test connector=connectors/destination-snowflake

🕑 connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/1752060194

yurii-bidiuk · 2022-01-26T17:08:41Z

/test connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/1752060832

yurii-bidiuk · 2022-01-26T17:08:52Z

/test connector=connectors/destination-redshift

🕑 connectors/destination-redshift https://github.com/airbytehq/airbyte/actions/runs/1752061937

yurii-bidiuk · 2022-01-26T17:09:02Z

/test connector=connectors/destination-postgres

🕑 connectors/destination-postgres https://github.com/airbytehq/airbyte/actions/runs/1752062505

yurii-bidiuk · 2022-01-26T17:12:15Z

/test connector=connectors/destination-snowflake

🕑 connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/1752077094
❌ connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/1752077094
🐛

yurii-bidiuk · 2022-01-26T17:12:27Z

/test connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/1752077819
❌ connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/1752077819
🐛

yurii-bidiuk · 2022-01-26T17:12:36Z

/test connector=connectors/destination-redshift

🕑 connectors/destination-redshift https://github.com/airbytehq/airbyte/actions/runs/1752078450
❌ connectors/destination-redshift https://github.com/airbytehq/airbyte/actions/runs/1752078450
🐛

yurii-bidiuk · 2022-01-26T17:12:44Z

/test connector=connectors/destination-postgres

🕑 connectors/destination-postgres https://github.com/airbytehq/airbyte/actions/runs/1752079332
❌ connectors/destination-postgres https://github.com/airbytehq/airbyte/actions/runs/1752079332
🐛

yurii-bidiuk · 2022-01-26T17:29:51Z

/test connector=connectors/destination-snowflake

🕑 connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/1752153922
❌ connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/1752153922
🐛

yurii-bidiuk · 2022-01-26T17:30:01Z

/test connector=connectors/destination-postgres

🕑 connectors/destination-postgres https://github.com/airbytehq/airbyte/actions/runs/1752154648
❌ connectors/destination-postgres https://github.com/airbytehq/airbyte/actions/runs/1752154648
🐛

yurii-bidiuk · 2022-01-26T17:30:08Z

/test connector=connectors/destination-redshift

🕑 connectors/destination-redshift https://github.com/airbytehq/airbyte/actions/runs/1752155133
❌ connectors/destination-redshift https://github.com/airbytehq/airbyte/actions/runs/1752155133
🐛

yurii-bidiuk · 2022-01-26T17:30:24Z

/test connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/1752156078
❌ connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/1752156078
🐛

...ion/java/io/airbyte/integrations/destination/bigquery/BigQueryDestinationAcceptanceTest.java

yurii-bidiuk · 2022-04-05T08:52:37Z

/test connector=connectors/destination-pubsub

🕑 connectors/destination-pubsub https://github.com/airbytehq/airbyte/actions/runs/2095050627
✅ connectors/destination-pubsub https://github.com/airbytehq/airbyte/actions/runs/2095050627
No Python unittests run

yurii-bidiuk · 2022-04-05T09:14:33Z

/publish connector=connectors/destination-pubsub

🕑 connectors/destination-pubsub https://github.com/airbytehq/airbyte/actions/runs/2095169564
✅ connectors/destination-pubsub https://github.com/airbytehq/airbyte/actions/runs/2095169564

…ompliant date string (#9816)" This reverts commit 2f850b9.

…ompliant date string (#9816)" (#11802) This reverts commit 2f850b9.

yurii-bidiuk temporarily deployed to more-secrets January 26, 2022 17:08 Inactive

octavia-squidington-iii temporarily deployed to more-secrets January 26, 2022 17:10 Inactive

octavia-squidington-iii temporarily deployed to more-secrets January 26, 2022 17:11 Inactive

github-actions bot added the area/connectors Connector related issues label Jan 26, 2022

yurii-bidiuk temporarily deployed to more-secrets January 26, 2022 17:13 Inactive

octavia-squidington-iii temporarily deployed to more-secrets January 26, 2022 17:14 Inactive

yurii-bidiuk force-pushed the bidiuk/5712-dat-iso8601-compliant-date-strings branch from c7cb0e2 to 0d48b8f Compare January 26, 2022 17:29

yurii-bidiuk temporarily deployed to more-secrets January 26, 2022 17:31 Inactive

octavia-squidington-iii temporarily deployed to more-secrets January 26, 2022 17:32 Inactive

yurii-bidiuk force-pushed the bidiuk/5712-dat-iso8601-compliant-date-strings branch from 0d48b8f to 0c282fa Compare January 26, 2022 17:42

yurii-bidiuk added 2 commits April 4, 2022 23:58

add comments

0d8ebb2

refactored iteration

905e454

yurii-bidiuk force-pushed the bidiuk/5712-dat-iso8601-compliant-date-strings branch 2 times, most recently from 0ce9188 to 4640ad7 Compare April 4, 2022 21:37

github-actions bot referenced this pull request Apr 4, 2022

format code

4640ad7

edgao reviewed Apr 4, 2022

View reviewed changes

...ion/java/io/airbyte/integrations/destination/bigquery/BigQueryDestinationAcceptanceTest.java Show resolved Hide resolved

edgao approved these changes Apr 4, 2022

View reviewed changes

...ion/java/io/airbyte/integrations/destination/bigquery/BigQueryDestinationAcceptanceTest.java Show resolved Hide resolved

format code

cd04ca4

yurii-bidiuk force-pushed the bidiuk/5712-dat-iso8601-compliant-date-strings branch from 4640ad7 to cd04ca4 Compare April 5, 2022 09:15

pubsub bump version

574afbd

yurii-bidiuk temporarily deployed to more-secrets April 5, 2022 10:38 Inactive

yurii-bidiuk merged commit 2f850b9 into master Apr 5, 2022

yurii-bidiuk deleted the bidiuk/5712-dat-iso8601-compliant-date-strings branch April 5, 2022 11:04

ChristopheDuong mentioned this pull request Apr 5, 2022

🐛 fix s3/gcs bucket cleanup #11728

Merged

40 tasks

yurii-bidiuk mentioned this pull request Apr 7, 2022

Revert "DAT: verify that a destination is able to write any ISO8601-compliant date string (#9816)" #11802

Merged

40 tasks

yurii-bidiuk added a commit that referenced this pull request Apr 7, 2022

Revert "DAT: verify that a destination is able to write any ISO8601-c…

9afcc7e

…ompliant date string (#9816)" This reverts commit 2f850b9.

yurii-bidiuk added a commit that referenced this pull request Apr 8, 2022

Revert "DAT: verify that a destination is able to write any ISO8601-c…

a688918

…ompliant date string (#9816)" This reverts commit 2f850b9.

yurii-bidiuk added a commit that referenced this pull request Apr 8, 2022

Revert "DAT: verify that a destination is able to write any ISO8601-c…

af1d087

…ompliant date string (#9816)" (#11802) This reverts commit 2f850b9.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DAT: verify that a destination is able to write any ISO8601-compliant date string #9816

DAT: verify that a destination is able to write any ISO8601-compliant date string #9816

yurii-bidiuk commented Jan 26, 2022 •

edited

Loading

yurii-bidiuk commented Jan 26, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Jan 26, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Jan 26, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Jan 26, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Jan 26, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Jan 26, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Jan 26, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Jan 26, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Jan 26, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Jan 26, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Jan 26, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Jan 26, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Apr 5, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Apr 5, 2022 •

edited by github-actions bot

Loading

DAT: verify that a destination is able to write any ISO8601-compliant date string #9816

DAT: verify that a destination is able to write any ISO8601-compliant date string #9816

Conversation

yurii-bidiuk commented Jan 26, 2022 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

yurii-bidiuk commented Jan 26, 2022 • edited by github-actions bot Loading

yurii-bidiuk commented Jan 26, 2022 • edited by github-actions bot Loading

yurii-bidiuk commented Jan 26, 2022 • edited by github-actions bot Loading

yurii-bidiuk commented Jan 26, 2022 • edited by github-actions bot Loading

yurii-bidiuk commented Jan 26, 2022 • edited by github-actions bot Loading

yurii-bidiuk commented Jan 26, 2022 • edited by github-actions bot Loading

yurii-bidiuk commented Jan 26, 2022 • edited by github-actions bot Loading

yurii-bidiuk commented Jan 26, 2022 • edited by github-actions bot Loading

yurii-bidiuk commented Jan 26, 2022 • edited by github-actions bot Loading

yurii-bidiuk commented Jan 26, 2022 • edited by github-actions bot Loading

yurii-bidiuk commented Jan 26, 2022 • edited by github-actions bot Loading

yurii-bidiuk commented Jan 26, 2022 • edited by github-actions bot Loading

yurii-bidiuk commented Apr 5, 2022 • edited by github-actions bot Loading

yurii-bidiuk commented Apr 5, 2022 • edited by github-actions bot Loading

yurii-bidiuk commented Jan 26, 2022 •

edited

Loading

yurii-bidiuk commented Jan 26, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Jan 26, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Jan 26, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Jan 26, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Jan 26, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Jan 26, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Jan 26, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Jan 26, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Jan 26, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Jan 26, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Jan 26, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Jan 26, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Apr 5, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Apr 5, 2022 •

edited by github-actions bot

Loading